Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Port for Posting Global Paths in Tests #365

Merged

Conversation

SPDonaghy
Copy link
Contributor

Description

Moved the test post_server from port 8081 to 8085.
Also refactored the test files a bit so that we only need to change one line to change the test port again if needed.

Verification

  • Ran the test task, but the local path tests might be running before NET on my machine

@SPDonaghy SPDonaghy self-assigned this Apr 25, 2024
@SPDonaghy SPDonaghy requested a review from jamenkaye as a code owner April 25, 2024 23:31
@SPDonaghy SPDonaghy marked this pull request as draft April 25, 2024 23:31
@SPDonaghy SPDonaghy added path Pathfinding team bug Something isn't working labels Apr 25, 2024
@SPDonaghy SPDonaghy requested a review from patrick-5546 April 25, 2024 23:41
@SPDonaghy SPDonaghy marked this pull request as ready for review April 25, 2024 23:42
Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Verified by running test task locally in main branch (failed) then in this branch (passed)

@SPDonaghy SPDonaghy enabled auto-merge (squash) April 29, 2024 05:05
@SPDonaghy SPDonaghy merged commit eda7dac into main Apr 29, 2024
10 checks passed
@SPDonaghy SPDonaghy deleted the user/SPDonaghy/change-port-for-global-path-tests-363 branch April 29, 2024 05:10
@patrick-5546 patrick-5546 removed the bug Something isn't working label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
path Pathfinding team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests start 2 http servers on the same port
2 participants